Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture loop var in TestClientDisabledRedirects #20466

Merged
merged 1 commit into from
May 2, 2023
Merged

Capture loop var in TestClientDisabledRedirects #20466

merged 1 commit into from
May 2, 2023

Conversation

mpalmi
Copy link
Contributor

@mpalmi mpalmi commented May 2, 2023

Without this change, test failures only report the last value of name:

 /Users/mpalmi/scm/vault-enterprise/api/client_test.go:258: Disabled redirects: Moved permanently: expected 3 request(s) but got 1
    /Users/mpalmi/scm/vault-enterprise/api/client_test.go:258: Disabled redirects: Moved permanently: expected 5 request(s) but got 1
    /Users/mpalmi/scm/vault-enterprise/api/client_test.go:258: Disabled redirects: Moved permanently: expected 4 request(s) but got 1
    /Users/mpalmi/scm/vault-enterprise/api/client_test.go:258: Disabled redirects: Moved permanently: expected 6 request(s) but got 2

Capturing the loop var results in the following output:

  /Users/mpalmi/scm/vault-enterprise/api/client_test.go:258: Disabled redirects: Temporary Redirect: expected 5 request(s) but got 1
    /Users/mpalmi/scm/vault-enterprise/api/client_test.go:258: Disabled redirects: Found: expected 4 request(s) but got 1
    /Users/mpalmi/scm/vault-enterprise/api/client_test.go:258: Disabled redirects: Moved permanently: expected 3 request(s) but got 1
    /Users/mpalmi/scm/vault-enterprise/api/client_test.go:258: Enable redirects: Moved permanently: expected 6 request(s) but got 2

@mpalmi mpalmi requested a review from a team May 2, 2023 17:24
@mpalmi mpalmi enabled auto-merge (squash) May 2, 2023 17:25
VioletHynes
VioletHynes approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@mpalmi mpalmi merged commit 60c3527 into main May 2, 2023
Merged
@mpalmi mpalmi deleted the capture-loop-var branch May 2, 2023 18:12
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VioletHynes VioletHynes VioletHynes approved these changes

Assignees
No one assigned
Labels
pr/no-changelog pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpalmi @VioletHynes