-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipe MountPoint to audit logs #20411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
via user-defined path
|
ncabatoff
approved these changes
Apr 27, 2023
via user-generated subpath
|
ncabatoff
reviewed
Apr 27, 2023
Co-authored-by: Nick Cabatoff <[email protected]>
swayne275
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eyyyyy first Vault PR! Great work!
would you mind backporting this to version 1.12.x also? i know I didn't specify that at the beginning, but it looks like clusters that currently have insights are running v1.12.x |
This was referenced Apr 27, 2023
clemon
added a commit
that referenced
this pull request
Apr 28, 2023
* MountPoint piped to audit logs --------- Co-authored-by: Nick Cabatoff <[email protected]>
clemon
pushed a commit
that referenced
this pull request
Apr 28, 2023
* MountPoint piped to audit logs --------- Co-authored-by: Nick Cabatoff <[email protected]>
clemon
added a commit
that referenced
this pull request
Apr 28, 2023
* MountPoint piped to audit logs --------- Co-authored-by: Nick Cabatoff <[email protected]>
clemon
pushed a commit
that referenced
this pull request
Apr 28, 2023
* MountPoint piped to audit logs --------- Co-authored-by: Nick Cabatoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VAULT-15882
required for Vault Insights, this PR simply pipes the existing
Request.MountPoint
into audit logs