Backport of Remove extraneous certificate from OCSP response into release/1.13.x #20203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/cipherboy-remove-issuers-from-ocsp-response/rarely-funny-hare
branch
2 times, most recently
from
2168cbc to
d52686d
Compare
cipherboy
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20201 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
The below text is copied from the body of the original PR.
Since the issuer used to sign the certificate also signs the OCSP response, no additional information is added by sending the issuer again in the
certsfield of theBasicOCSPResponsestructure. Removing it saves bytes and avoids confusing Go-based OCSP verifiers which cannot handle the cert issuer being duplicated in thecertsfield.This complements #20181; if anyone uses a different cluster for Vault PKI from Cert Auth and are running Vault 1.12.x, they could update that cluster to a future 1.12 Vault release, instead of (or in addition to) updating the cluster running Cert Auth to a newer 1.13 version. This additionally improves compatibility with any other Go OCSP validation that may be occurring (e.g., Snowflake or others as reported on the upstream Go issue).
Overview of commits