Backport of Forward PKI revocation requests received by standby nodes to active node into release/1.13.x #19630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hc-github-team-secure-vault-core
force-pushed
the
backport/stevendpclark/vault-14665-pki-revocation-standby/publicly-better-mastiff
branch
2 times, most recently
from
3c17cf7 to
e257377
Compare
…ode (#19624) * Forward PKI revocation requests received by standby nodes to active node - A refactoring that occurred in 1.13 timeframe removed what was considered a specific check for standby nodes that wasn't required as a writes should be returning ErrReadOnly. - That sadly exposed a long standing bug where the errors from the storage layer were not being properly wrapped, hiding the ErrReadOnly coming from a write and failing the request. * Add cl * Add test for basic PKI operations against standby nodes
stevendpclark
force-pushed
the
backport/stevendpclark/vault-14665-pki-revocation-standby/publicly-better-mastiff
branch
from
c36b68d to
d767d4c
Compare
stevendpclark
approved these changes
Mar 20, 2023
…-pki-revocation-standby/publicly-better-mastiff
stevendpclark
deleted the
backport/stevendpclark/vault-14665-pki-revocation-standby/publicly-better-mastiff
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19624 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Overview of commits