Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs / update 'vault plugin deregister' command doc #19573

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

rowansmithhc
Copy link
Contributor

@rowansmithhc rowansmithhc commented Mar 15, 2023

https://developer.hashicorp.com/vault/docs/commands/plugin/deregister does not show the information relevant to the additional parameter -version= that is included from Vault 1.12.0 onwards - https://github.com/hashicorp/vault/blob/v1.12.0/command/plugin_deregister.go#L59 and the commit that added it: https://github.com/hashicorp/vault/pull/16856/files#diff-068ff36161239648c34a6fd7e1c450f20e249215ad8e4c7aaf0e6bfcbdb80ebbR59

On the https://github.com/hashicorp/vault/blob/main/CHANGELOG.md as plugins: Add plugin version to auth register, list, and mount table [https://github.com/hashicorp/vault/pull/16856]

preview: https://vault-ktctkyqtj-hashicorp.vercel.app/vault/docs/commands/plugin/deregister

adding `-version=` parameter to docs
@yhyakuna yhyakuna merged commit 28b0037 into main Mar 20, 2023
yhyakuna pushed a commit that referenced this pull request Mar 20, 2023
adding `-version=` parameter to docs
@yhyakuna yhyakuna deleted the rowansmithhc-patch-1 branch March 20, 2023 19:53
yhyakuna added a commit that referenced this pull request Mar 20, 2023
adding `-version=` parameter to docs

Co-authored-by: Rowan Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants