Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for importing RSA-PSS keys into Transit #19519

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

cipherboy
Copy link
Contributor

RSA-PSS keys would fail with the error:

$ vault transit import transit/keys/OS_key_test2 @newkey-pss.der.b64 type=rsa-2048
Retrieving transit wrapping key.
Wrapping source key with ephemeral key.
Encrypting ephemeral key with transit wrapping key.
Submitting wrapped key to Vault transit.
failed to call import:Error making API request.

URL: PUT http://localhost:8200/v1/transit/keys/OS_key_test2/import
Code: 500. Errors:

* 1 error occurred:
	* error importing key: error parsing asymmetric key: x509: PKCS#8 wrapping contained private key with unknown algorithm: 1.2.840.113549.1.1.10

This adds custom PKCS8 parsing along the lines of our existing Ed25519 key parsing, though much simpler since the inner structure is simply a PKCS1 blob (which can be decoded by the standard library).

@cipherboy cipherboy added this to the 1.14 milestone Mar 13, 2023
@cipherboy cipherboy requested review from schultz-is, sgmiller and a team March 13, 2023 16:33
@cipherboy cipherboy force-pushed the cipherboy-pss-for-transit-byok branch from ea59a94 to 77c8616 Compare March 13, 2023 16:34
Copy link
Contributor

@schultz-is schultz-is left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cipherboy cipherboy enabled auto-merge (squash) March 13, 2023 16:39
@cipherboy cipherboy merged commit 9e18897 into main Mar 13, 2023
raymonstah pushed a commit that referenced this pull request Mar 17, 2023
* Add support for importing RSA-PSS keys in Transit

Signed-off-by: Alexander Scheel <[email protected]>

* Add changelog entry

Signed-off-by: Alexander Scheel <[email protected]>

---------

Signed-off-by: Alexander Scheel <[email protected]>
@cipherboy cipherboy deleted the cipherboy-pss-for-transit-byok branch April 21, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants