Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove .mdx extension from link #19514

Merged
merged 1 commit into from
Mar 13, 2023
Merged

fix: Remove .mdx extension from link #19514

merged 1 commit into from
Mar 13, 2023

Conversation

ashleemboyer
Copy link
Contributor

Removes an .mdx extension from a link, which was causing a 404 when clicked.

@ashleemboyer ashleemboyer requested a review from yhyakuna as a code owner March 13, 2023 13:47
@ashleemboyer ashleemboyer added docs website Code changes specifically for the docs website pr/no-changelog labels Mar 13, 2023
mladlow
mladlow approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@mladlow mladlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure for our workflow this needs to get on the 1.13 release branch to be published immediately, but correct me if I'm wrong. I added the backport label.

@ashleemboyer
Copy link
Contributor Author

Pretty sure for our workflow this needs to get on the 1.13 release branch to be published immediately, but correct me if I'm wrong. I added the backport label.

@mladlow that sounds correct to me! 👍🏻 This is all good to go on my side, but I'm not able to merge. Feel free to merge if you're able to! 😊

@mladlow mladlow merged commit 55bf601 into main Mar 13, 2023
Merged
@mladlow mladlow deleted the ashleemboyer-patch-1 branch March 13, 2023 19:03
raymonstah pushed a commit that referenced this pull request Mar 17, 2023
@ashleemboyer @raymonstah
Remove .mdx extension from link (#19514)
edef778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mladlow mladlow mladlow approved these changes

@yhyakuna yhyakuna Awaiting requested review from yhyakuna

Assignees
No one assigned
Labels
docs pr/no-changelog website Code changes specifically for the docs website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashleemboyer @mladlow