sdk: Fix fmt + add FieldType test #19493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcboudreau
approved these changes
Mar 9, 2023
| @@ -753,7 +753,7 @@ func (t FieldType) Zero() interface{} { | |||
| case TypeInt: | |||
| return 0 | |||
| case TypeInt64: | |||
| return int64(0) | |||
| return int64(0) | |||
raymonstah
pushed a commit
that referenced
this pull request
Mar 17, 2023
* sdk: Fix fmt + add FieldType test * Add test comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #18729 to fix the fmt job (trailing whitespace) and help prevent regressions in the future.