Fix failing TestHCPLinkConnected Test #19474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l from test that rely on env being modified.
marcboudreau
force-pushed
the
marcboudreau/fix-broken-test
branch
from
dec3deb to
d806629
Compare
raymonstah
pushed a commit
that referenced
this pull request
Mar 17, 2023
* replace use of os.Unsetenv in test with t.Setenv and remove t.Parallel from test that rely on env being modified. * experiment with using fromJSON function * revert previous experiment * including double quotes in the output value for the string ubuntu-latest * use go run to launch gofumpt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few minor corrections to avoid race conditions with the tests. It also corrects a syntax issue that led to most jobs from the CI GitHub Actions Workflow to be skipped.
In the end, the actual cause of the failing TestHCPLinkConnected test was that the HCP Link resource ended up in the unlinking state, so a new resource needed to be created and the associated secrets were updated.