Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi: Add display attributes for Radius auth #19392

Merged
merged 41 commits into from
Apr 7, 2023
Merged

Conversation

averche
Copy link
Contributor

@averche averche commented Feb 28, 2023

Please see #19319 for more details on how this will affect the generated OpenAPI schema.


The following OperationID's will be generated for Radius auth:

radius-read-configuration
radius-configure
radius-log-in
radius-log-in-with-username
radius-list-users
radius-read-user
radius-write-user
radius-delete-user

@averche averche marked this pull request as ready for review February 28, 2023 16:18
@averche averche requested a review from a team February 28, 2023 16:19
@averche averche added this to the 1.14 milestone Mar 1, 2023
DisplayAttrs: &framework.DisplayAttributes{
OperationPrefix: operationPrefixRadius,
OperationVerb: "login",
OperationSuffix: "|with-username",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this result in 2 separate operation IDs for w/ and without user name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap:

radius-login
radius-login-with-username

Base automatically changed from ui/openapi-naming-strategy to main April 4, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants