Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi: Add display attributes for Okta auth #19391

Merged
merged 43 commits into from
Apr 13, 2023
Merged

Conversation

averche
Copy link
Contributor

@averche averche commented Feb 28, 2023

Please see #19319 for more details on how this will affect the generated OpenAPI schema.


The following OperationID's will be generated for Okta auth:

okta-read-configuration
okta-configure
okta-list-groups
okta-read-group
okta-write-group
okta-delete-group
okta-log-in
okta-list-users
okta-read-user
okta-write-user
okta-delete-user
okta-verify

@averche averche added this to the 1.14 milestone Feb 28, 2023
@averche averche marked this pull request as ready for review February 28, 2023 16:17
@averche averche requested a review from a team February 28, 2023 16:17
logical.CreateOperation: &framework.PathOperation{
Callback: b.pathConfigWrite,
DisplayAttrs: &framework.DisplayAttributes{
OperationVerb: "configure",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be any limitations on what plugin authors can provide for OperationVerb or OperationSuffix? If so, is there a place for developers to discover this information?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are currently no limitations, just suggestions. In general the OperationID's will be constructed with prefix + verb + suffix. If not specified, these will be implied from the path / mount path. I'll see if we can add more guidelines to tutorials/docs.

Base automatically changed from ui/openapi-naming-strategy to main April 4, 2023 17:14
@averche averche merged commit f82e6f3 into main Apr 13, 2023
@averche averche deleted the display-attributes-okta branch April 13, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants