docs(kubernetes-auth): add API documentation for kubernetes auth namespace selectors #19318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…space selectors Relates-to: hashicorp/vault-plugin-auth-kubernetes#182
…for namespace label selection Relates-to: hashicorp/vault-plugin-auth-kubernetes#182
|
Hi @yhyakuna , maybe I can get some attention here. The PR on the plugin repo has been open for very long, and some people including myself are waiting for this feature. Is there anything I can do on these PRs to speed up a review? |
thyton
reviewed
Dec 18, 2023
|
Hi @f4z3r. Thank you for submitting the PR and changes. It looks good to me. I'll check with @hashicorp/vault-education-approvers to see if we miss anything here. Thank you for your patience! |
Monkeychip
pushed a commit
that referenced
this pull request
Feb 5, 2024
…space selectors (#19318) Co-authored-by: Thy Ton <[email protected]>
Monkeychip
pushed a commit
that referenced
this pull request
Feb 7, 2024
…space selectors (#19318) Co-authored-by: Thy Ton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates-to: hashicorp/vault-plugin-auth-kubernetes#182
Adds the API documentation for allowing the use of label selectors to validate the ServiceAccount namespace being authenticated.