Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds test coverage for PR 19190 #19226

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Adds test coverage for PR 19190 #19226

merged 1 commit into from
Feb 16, 2023

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented Feb 16, 2023 •
edited
Loading

See PR here and the reason I didn't add test coverage in that PR.

Note: The test was originally included in the PR and so it's been reviewed/approved.

@Monkeychip Monkeychip added this to the 1.13.1 milestone Feb 16, 2023
@Monkeychip Monkeychip marked this pull request as ready for review February 16, 2023 18:24
kiannaquach
kiannaquach approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@kiannaquach kiannaquach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding!

@Monkeychip Monkeychip merged commit d6f65dd into main Feb 16, 2023
@Monkeychip Monkeychip deleted the ui/VAULT-12528/db-fix-test-coverage branch February 16, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiannaquach kiannaquach kiannaquach approved these changes

Assignees
No one assigned
Labels
pr/no-changelog ui
Projects
None yet
Milestone
1.13.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Monkeychip @kiannaquach