Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error message when trying to rotate mssql root without password in configuration #19103

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

elliesterner
Copy link
Contributor

@elliesterner elliesterner commented Feb 9, 2023

Previously when trying to rotate the root credential in mssql, a user would see this error. This also caused a panic in vault server:

vault write -f database/rotate-root/mydb ;
  # Error writing data to database/rotate-root/mydb: Put "http://127.0.0.1:8200/v1/database/rotate-root/mydb": EOF

This fix returns a more helpful message:

vault write -f database/rotate-root/mydb ;                  10:39:53

Error writing data to database/rotate-root/mydb: Error making API request.

URL: PUT http://localhost:8200/v1/database/rotate-root/mydb
Code: 500. Errors:

* 1 error occurred:
	* unable to rotate root credentials: no password in configuration

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…n configuration
@elliesterner elliesterner requested a review from a team February 9, 2023 15:44
@elliesterner elliesterner marked this pull request as draft February 9, 2023 15:48
@elliesterner elliesterner marked this pull request as ready for review February 10, 2023 15:05
Copy link
Contributor

@davidadeleon davidadeleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ltcarbonell ltcarbonell self-requested a review February 10, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants