Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: CLI Doc improvements to example read / write. #19064

Merged
merged 11 commits into from
Aug 9, 2024

Conversation

aphorise
Copy link
Contributor

@aphorise aphorise commented Feb 8, 2023

Replaces PR: #17011 & expected to to resolve: #16788

@aphorise aphorise changed the title Core: CLI Doc imporvements to example read / write. Core: CLI Doc improvements to example read / write. Feb 8, 2023
@aphorise aphorise requested a review from ncabatoff May 25, 2023 09:47
command/read.go Show resolved Hide resolved
command/read.go Show resolved Hide resolved
command/read.go Show resolved Hide resolved
@VioletHynes VioletHynes added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 7, 2023
Copy link
Contributor

@biazmoreira biazmoreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But would be good to obtain @ncabatoff's review as well before merging it since he originally reviewed this PR

Copy link

github-actions bot commented Jun 28, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Jun 28, 2024

Build Results:
All builds succeeded! ✅

@mladlow mladlow added this to the 1.18.0-rc milestone Aug 9, 2024
@mladlow
Copy link
Collaborator

mladlow commented Aug 9, 2024

I've gone ahead and merged this because I think it seems like an improvement and like it should sufficiently address the original issue.

@mladlow mladlow merged commit 88975a6 into main Aug 9, 2024
90 of 92 checks passed
@mladlow mladlow deleted the cli/help-docs-write-read branch August 9, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading --help message and examples for vault read and vault write
5 participants