-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/vault 12818/oracle banner sll #19019
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
dd3013f
glimmerize alert-banner
Monkeychip 04d7cc3
Merge branch 'main' into ui/VAULT-12818/oracle-banner-sll
Monkeychip 7873058
structure for the DocLink todo: css important remove
Monkeychip 7726c8f
styling done. kind of strange, but should help in future
Monkeychip 748b1e2
clean up
Monkeychip de88cb6
test coverage
Monkeychip 1891c3e
changelog
Monkeychip ccf038f
address pr comments
Monkeychip aa372cd
clean up
Monkeychip 4a9ba1a
amended language on banner to match most recent change.
Monkeychip 94fba05
add return
Monkeychip a9417a9
clean up
Monkeychip 94fef5f
merge main
Monkeychip 41ec28b
Merge branch 'main' into ui/VAULT-12818/oracle-banner-sll
Monkeychip 05261dd
modify the banner title and shorten message
Monkeychip 8d7c73d
update language
Monkeychip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
```release-note: improvement | ||
ui: Add alert-banner about configuring an Oracle DB secret engine if using SSL. | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -229,6 +229,12 @@ const connectionTests = [ | |
assert | ||
.dom('[data-test-input="root_rotation_statements"]') | ||
.exists(`Root rotation statements exists for ${name}`); | ||
assert | ||
.dom('[data-test-alert-banner="alert"]') | ||
.hasTextContaining( | ||
`Warning Please ensure that your Oracle plugin has the default name of vault-plugin-database-oracle. Custom naming is not supported in the UI at this time. If the plugin is already named vault-plugin-database-oracle, disregard this warning.`, | ||
'warning banner displays about connections with SSL.' | ||
); | ||
}, | ||
}, | ||
]; | ||
|
@@ -264,7 +270,7 @@ module('Acceptance | secrets/database/*', function (hooks) { | |
}); | ||
|
||
test('Connection create and edit form for each plugin', async function (assert) { | ||
assert.expect(160); | ||
assert.expect(169); | ||
const backend = await mount(); | ||
for (const testCase of connectionTests) { | ||
await connectionPage.visitCreate({ backend }); | ||
|
@@ -287,6 +293,11 @@ module('Acceptance | secrets/database/*', function (hooks) { | |
testCase.requiredFields(assert, testCase.name); | ||
continue; | ||
} | ||
if (testCase.plugin !== 'vault-plugin-database-oracle') { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks for adding test coverage!! |
||
assert | ||
.dom('[data-test-alert-banner="alert"]') | ||
.doesNotExist('Does not show alert-banners specific only to the Oracle db.'); | ||
} | ||
testCase.requiredFields(assert, testCase.name); | ||
await connectionPage.toggleVerify(); | ||
await connectionPage.save(); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤯