Make API not depend on SDK #18962
Merged
Make API not depend on SDK #18962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcboudreau
reviewed
Feb 2, 2023
marcboudreau
approved these changes
Feb 2, 2023
|
The PR didn't build, there was a further change needed. I could've made that change smaller by casting between the consts versions of plugintypes and the api version, but this felt more appropriate since most of the code in question was then talking to api plugin methods. Happy to revisit that decision if this seems unpalatable to folks. |
tomhjp
approved these changes
Feb 3, 2023
ncabatoff
added a commit
to hashicorp/vault-testing-stepwise
that referenced
this pull request
Feb 3, 2023
…f plugintypes. We have to use the branch version of the api for this for now, until that PR is merged, but we can't wait because we're blocking that PR without this change.
…lure. Once this PR is merged, that one can be merged, and then we can remove the temporary branch versions for stepwise in vault and for api in stepwise.
ncabatoff
added a commit
to hashicorp/vault-testing-stepwise
that referenced
this pull request
Feb 3, 2023
…f plugintypes. We have to use the branch version of the api for this for now, until that PR is merged, but we can't wait because we're blocking that PR without this change. (#4)
blankdots
added a commit
to CSCfi/vault-testing-stepwise
that referenced
this pull request
Feb 21, 2023
naphelps
pushed a commit
to openbao/openbao
that referenced
this pull request
Jan 23, 2024
* Initial commit * Import stepwise from current Vault snapshot * Update deps * Update dependencies for Vault 1.9 * Update containerd to fix issue with docker libs - docker brought in a broken containerd version v1.3.4 which resulted in an `undefined` error. * [COMPLIANCE] Update MPL 2.0 LICENSE * Unbreak hashicorp/vault#18962 by transitioning away from local copy of plugintypes. We have to use the branch version of the api for this for now, until that PR is merged, but we can't wait because we're blocking that PR without this change. (#4) * update dependencies * fix vault docker image * Fix deps to rewrite hashicorp/vault to openbao/openbao Signed-off-by: Alexander Scheel <[email protected]> * Use imported sdk/helper/stepwise over vault-testing-stepwise Note that this package is in the SDK so it remains importable by third-party plugins wishing to test against our instance. However, this allows it to be maintained alongside our distribution and is one fewer external dependency to maintain. Signed-off-by: Alexander Scheel <[email protected]> --------- Signed-off-by: Alexander Scheel <[email protected]> Co-authored-by: Jeff Mitchell <[email protected]> Co-authored-by: Ben Ash <[email protected]> Co-authored-by: Ben Ash <[email protected]> Co-authored-by: hashicorp-copywrite[bot] <[email protected]> Co-authored-by: Caleb Albers <[email protected]> Co-authored-by: Nick Cabatoff <[email protected]> Co-authored-by: Raymond Ho <[email protected]> Co-authored-by: Raymond Ho <[email protected]> Co-authored-by: JM Faircloth <[email protected]> Co-authored-by: John-Michael Faircloth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow api users to have fewer dependencies, and will allow sdk to depend on api. The cost is a little bit of duplication of code/types/constants but it seems like a reasonable trade-off.