Change gen_openapi.sh to generate schema with generic mount paths #18934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnPucel
reviewed
Jan 31, 2023
AnPucel
reviewed
Jan 31, 2023
| @@ -36,7 +36,7 @@ while read -r line; do | |||
| codeLinesStarted=true | |||
| elif [[ $line == *"databasePlugins:"* ]] ; then | |||
| break | |||
| elif [ $codeLinesStarted = true ] && [[ $line == *"consts.Deprecated"* || $line == *"consts.PendingRemoval"* ]] ; then | |||
| elif [ $codeLinesStarted = true ] && [[ $line == *"consts.Deprecated"* || $line == *"consts.PendingRemoval"* || $line == *"consts.Removed"* ]] ; then | |||
There was a problem hiding this comment.
Is this based off the comments in the registry like we previously had it? Or is this something new?
There was a problem hiding this comment.
Just out of curiosity b/c I don't remember anything that had said PendingRemoval or Removed
There was a problem hiding this comment.
They are no longer comments but actual struct values:
vault/helper/builtinplugins/registry.go
Lines 100 to 103 in fd9cadb
What we are doing here (parsing Go code in shell) is kind of gross. I'm just fixing the script while we are still using it.
There was a problem hiding this comment.
oh okay! gotcha. At least the deprecation status is codified in here though.
AnPucel
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gen_openapi.shis a script used to generateOpenAPIschema for all built-in plugins. The resultantopenapi.jsonschema is then used for client library generation.This pull request fixes a couple issues:
generic_mount_pathsset to true, inserting/{thing_mount_path}/elements into the paths for certain plugins. This was the default behavior before Revert "Add mount path into the default generated openapi.json spec (#17926)" #18617. We are now re-enabling the behavior but specifically for the schemas generated using this script.