VAULT-12833 Update prompts for the rekey command #18892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miagilepner
force-pushed
the
miagilepner/VAULT-12833-rekey-recovery
branch
from
9ffd602 to
8565c00
Compare
miagilepner
commented
Jan 30, 2023
| // the function returns a client, the recovery keys, and a closer function | ||
| func testVaultServerAutoUnseal(tb testing.TB) (*api.Client, []string, func()) { | ||
| testSeal := seal.NewTestSeal(nil) | ||
| autoSeal, err := vault.NewAutoSeal(testSeal) |
There was a problem hiding this comment.
I'm not sure if there's a better way to set up auto-unseal for testing
There was a problem hiding this comment.
Depends on what you're trying to do. I think you made the right choice here. If we were actually exercising seal related more directly, I might point you at something that doesn't use a NewTestSeal, which is kind of a fake.
ncabatoff
approved these changes
Jan 30, 2023
| // the function returns a client, the recovery keys, and a closer function | ||
| func testVaultServerAutoUnseal(tb testing.TB) (*api.Client, []string, func()) { | ||
| testSeal := seal.NewTestSeal(nil) | ||
| autoSeal, err := vault.NewAutoSeal(testSeal) |
There was a problem hiding this comment.
Depends on what you're trying to do. I think you made the right choice here. If we were actually exercising seal related more directly, I might point you at something that doesn't use a NewTestSeal, which is kind of a fake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the prompts for the rekey command currently assume that the
-targetflag is set to its default value ofbarrier. If the-target=recoveryoption is set, then the prompts should instead describe recovery keys. I updated the language and added some tests around recovery keys.