Transit Import Key CLI functionality #18887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitography
reviewed
Jan 27, 2023
| wrappedTargetKey, err := wrapKWP.Wrap(key) | ||
| if err != nil { | ||
| c.UI.Error(fmt.Sprintf("failure wrapping source key: %v", err)) | ||
| return 2 |
There was a problem hiding this comment.
what are your return codes / are they documented somewhere? (in particular 1 vs. 2 vs 3 as failures)
|
Apparently cli commands don't have unit tests? The actual import algo is covered by the unit tests in transit though. |
stevendpclark
approved these changes
Jan 27, 2023
Co-authored-by: Steven Clark <[email protected]>
CLI does have unit tests, see e.g., |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds transit import/import-key to bring keys into transit and transform via
the key wrapping protocol.