Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VAULT-12542 Add info encouraging users to upgrade if agent version is different to server #18684

Merged
merged 3 commits into from
Jan 13, 2023
Merged

VAULT-12542 Add info encouraging users to upgrade if agent version is different to server #18684

merged 3 commits into from
Jan 13, 2023

Conversation

VioletHynes
Copy link
Contributor

Appears like this:

violet@violet-TX54KFJWXM vault % vault agent -config=../vault_agent.hcl
==> Note: Vault Agent is not running with the same version as Vault itself, we recommend you upgrade! Vault Agent version: 1.13.0-dev1, Vault version: 1.12.0-rc1
==> Vault Agent started! Log data will stream in below:

image

@VioletHynes VioletHynes added this to the 1.13.0-rc1 milestone Jan 12, 2023
@VioletHynes VioletHynes requested review from ncabatoff and peteski22 and removed request for ncabatoff January 12, 2023 18:57
@VioletHynes VioletHynes marked this pull request as ready for review January 12, 2023 18:57
@VioletHynes VioletHynes requested a review from ncabatoff January 12, 2023 18:57
@VioletHynes
Copy link
Contributor Author

Open to update ideas on the message. I tried to keep it as not-'warning-y' as possible, as yeah, we do strive to maintain backwards compatibility where possible.

peteski22
peteski22 reviewed Jan 13, 2023
View reviewed changes
command/agent.go Outdated Show resolved Hide resolved
@VioletHynes VioletHynes merged commit 819c9e0 into main Jan 13, 2023
@raskchanky raskchanky deleted the violethynes/VAULT-12542 branch January 13, 2023 19:35
AnPucel pushed a commit that referenced this pull request Feb 3, 2023
@VioletHynes @AnPucel
VAULT-12542 Add info encouraging users to upgrade if agent version is…
080d007 
… different to server (#18684)

* VAULT-12542 Add info encouraging users to upgrade if agent version is different to server

* VAULT-12542 Changelog

* VAULT-12542 Language update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteski22 peteski22 peteski22 approved these changes

@ncabatoff ncabatoff Awaiting requested review from ncabatoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@VioletHynes @peteski22