UI: pki import issuer #18634
Merged
UI: pki import issuer #18634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellobontempo
commented
Jan 9, 2023
ui/app/adapters/pki/issuer.js
Outdated
| } else { | ||
| // TODO WIP generate | ||
| const type = 'root' || 'generate'; | ||
| // record.type is internal or exported |
There was a problem hiding this comment.
This is the pattern I used for generating vs importing a pki key here
hellobontempo
commented
Jan 9, 2023
| const { record, adapterOptions } = snapshot; | ||
| let url = this.urlForQuery(record.backend); | ||
| if (adapterOptions.import) { | ||
| url = `${url}/import/bundle`; |
There was a problem hiding this comment.
issuers/import/bundle accepts both certificate and keys, issuers/import/cert only accepts a certificate and errors if sent a key. After chatting with crypto, confirmed that UI should just use /bundle
hashishaw
approved these changes
Jan 9, 2023
ui/app/adapters/pki/issuer.js
Outdated
| url = `${url}/import/bundle`; | ||
| } else { | ||
| // TODO WIP generate | ||
| const type = 'root' || 'generate'; |
There was a problem hiding this comment.
The type here will never be generate, am I reading that right? If this is still WIP maybe it's best to throw an error or assertion here so we don't forget about it
There was a problem hiding this comment.
I think i mis-typed this and it should be root or intermediate
| @@ -43,9 +44,13 @@ export function parseCertificate(certificateContent) { | |||
| // field themselves are Time values. | |||
| const expiryDate = cert?.notAfter?.value; | |||
| const issueDate = cert?.notBefore?.value; | |||
| const serialNumber = Convert.ToHex(cert.serialNumber.valueBlock.valueHex) | |||
There was a problem hiding this comment.
Yeah 🥴 this took way longer than I want to admit
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
* create pki ca import component * add serial number to cert parser * convert to ts * remove comments * reset yarn.lock * fixed yarn lock * fix comment * add declaration for base cert
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
* create pki ca import component * add serial number to cert parser * convert to ts * remove comments * reset yarn.lock * fixed yarn lock * fix comment * add declaration for base cert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR imports the issuer along with adds the serial number data to the certificate parsing helper