db plugin: support multiline revoke stmt in postgres #18632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robmonte
approved these changes
Jan 9, 2023
| "username": username, | ||
| } | ||
| if err := dbtxn.ExecuteTxQueryDirect(ctx, tx, m, stmt); err != nil { | ||
| return err |
There was a problem hiding this comment.
Do you think it'd be a good idea to wrap this error so it's labeled as a multiline query that was attempted?
return fmt.Errorf("failed to execute multiline query: %w", err)
There was a problem hiding this comment.
I think I will leave this one as is since we already aren't doing it for creation
fairclothjm
deleted the
dbplugin/postgres-revoke-support-multiline-str
branch
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
* db plugin: support multiline revoke stmt in postgres * add changelong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the existing helper function to enable parsing multiline strings in revocation statements like we do for creation statements.
fixes: #15678