Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new clients into the monthly breakdown #18629

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Conversation

raskchanky
Copy link
Contributor

@raskchanky raskchanky commented Jan 7, 2023

When viewing the monthly breakdown in the output, if you looked under new_clients:

  • if you were viewing the current month only, you would see a namespace breakdown
  • if you were viewing historical data only, you would see a namespace breakdown
  • if you were viewing a date range that spanned both historical data as well as the current month, you'd see nothing

This PR rectifies this by showing the namespace breakdown for new clients in all 3 date range permutations, instead of only the first 2.

@raskchanky raskchanky marked this pull request as ready for review January 9, 2023 21:41
@raskchanky raskchanky requested a review from ccapurso January 9, 2023 21:44
@raskchanky raskchanky added this to the 1.13.0-rc1 milestone Jan 9, 2023
@raskchanky raskchanky merged commit d641bbc into main Jan 9, 2023
@raskchanky raskchanky deleted the lol-activity-log-again branch January 9, 2023 23:26
AnPucel pushed a commit that referenced this pull request Jan 14, 2023
* Add new clients into the monthly breakdown

* add changelog
peteski22 pushed a commit that referenced this pull request Jan 16, 2023
peteski22 pushed a commit that referenced this pull request Jan 16, 2023
AnPucel pushed a commit that referenced this pull request Feb 3, 2023
* Add new clients into the monthly breakdown

* add changelog
AnPucel pushed a commit that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants