-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PKI Responses Part 4 #18612
PKI Responses Part 4 #18612
Conversation
Co-authored-by: Daniel Huckins <[email protected]>
Co-authored-by: Daniel Huckins <[email protected]>
For the time or duration related fields please consider using either vault/sdk/framework/openapi.go Lines 805 to 807 in 40f599b
vault/sdk/framework/openapi.go Lines 785 to 787 in 40f599b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions regarding Required/Optional, otherwise LGTM.
For the "keys"
field, typically all the “LIST” request return “keys” in every successful code path (hence Required: true). If that doesn’t apply, feel free to ignore those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding these!
Responses for files:
path_resign_crls
,path_revoke
,path_roles
,path_root
,path_sign_issuers
, andpath_tidy
Please see this RFC for implementation details.
Related PRs: