Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKI Responses Part 4 #18612

Merged
merged 42 commits into from
Mar 14, 2023
Merged

PKI Responses Part 4 #18612

merged 42 commits into from
Mar 14, 2023

Conversation

AnPucel
Copy link
Contributor

@AnPucel AnPucel commented Jan 6, 2023

Responses for files: path_resign_crls, path_revoke, path_roles, path_root, path_sign_issuers, and path_tidy

Please see this RFC for implementation details.

Related PRs:

@AnPucel AnPucel marked this pull request as ready for review January 9, 2023 21:12
@AnPucel AnPucel requested a review from a team January 9, 2023 21:12
@AnPucel AnPucel added this to the 1.13.0-rc1 milestone Jan 9, 2023
@AnPucel AnPucel requested a review from a team January 9, 2023 21:51
builtin/logical/pki/path_revoke.go Outdated Show resolved Hide resolved
builtin/logical/pki/path_roles.go Outdated Show resolved Hide resolved
builtin/logical/pki/path_roles.go Outdated Show resolved Hide resolved
builtin/logical/pki/path_roles.go Outdated Show resolved Hide resolved
builtin/logical/pki/path_root.go Outdated Show resolved Hide resolved
builtin/logical/pki/path_tidy.go Outdated Show resolved Hide resolved
builtin/logical/pki/path_tidy.go Outdated Show resolved Hide resolved
builtin/logical/pki/path_tidy.go Outdated Show resolved Hide resolved
builtin/logical/pki/path_tidy.go Outdated Show resolved Hide resolved
builtin/logical/pki/path_tidy.go Outdated Show resolved Hide resolved
@averche averche self-requested a review February 6, 2023 22:51
@averche
Copy link
Contributor

averche commented Feb 6, 2023

For the time or duration related fields please consider using either framework.TypeTime or framework.TypeDurationSeconds as these will translate better in the generated code.

case TypeTime:
ret.baseType = "string"
ret.format = "date-time"

case TypeDurationSecond, TypeSignedDurationSecond:
ret.baseType = "integer"
ret.format = "seconds"

Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions regarding Required/Optional, otherwise LGTM.

For the "keys" field, typically all the “LIST” request return “keys” in every successful code path (hence Required: true). If that doesn’t apply, feel free to ignore those.

builtin/logical/pki/path_revoke.go Show resolved Hide resolved
builtin/logical/pki/path_roles.go Show resolved Hide resolved
builtin/logical/pki/path_revoke.go Show resolved Hide resolved
builtin/logical/pki/path_revoke.go Show resolved Hide resolved
builtin/logical/pki/path_revoke.go Show resolved Hide resolved
builtin/logical/pki/path_tidy.go Show resolved Hide resolved
Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding these!

@AnPucel AnPucel enabled auto-merge (squash) March 14, 2023 20:44
@AnPucel AnPucel merged commit 4ecb18b into main Mar 14, 2023
@AnPucel AnPucel deleted the anpucel/PKIResponse4 branch March 14, 2023 22:10
raymonstah pushed a commit that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants