Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

named Login MFA methods #18610

Merged
merged 19 commits into from
Jan 23, 2023
Merged

named Login MFA methods #18610

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
57f06fe
named MFA method configurations
hghaf099 Jan 4, 2023
8184ad9
fix a test
hghaf099 Jan 5, 2023
ae478f5
CL
hghaf099 Jan 6, 2023
ce35cb0
fix an issue with same config name different ID and add a test
hghaf099 Jan 6, 2023
e410f58
feedback
hghaf099 Jan 10, 2023
486056a
feedback on test
hghaf099 Jan 11, 2023
f47111f
consistent use of passcode for all MFA methods (#18611)
hghaf099 Jan 12, 2023
b510b04
only accept MFA method name with its namespace path in the login requ…
hghaf099 Jan 12, 2023
fa3fb2d
fix a bug
hghaf099 Jan 13, 2023
5b8175b
fixing an ErrorOrNil return value
hghaf099 Jan 16, 2023
210d699
more informative error message
hghaf099 Jan 16, 2023
de27415
Apply suggestions from code review
hghaf099 Jan 17, 2023
f84b537
feedback
hghaf099 Jan 17, 2023
e0254e1
test refactor a bit
hghaf099 Jan 18, 2023
8cff465
adding godoc for a test
hghaf099 Jan 19, 2023
a6f2df8
Merge branch 'main' into login-mfa-named-methods
hghaf099 Jan 20, 2023
bdb09ba
feedback
hghaf099 Jan 20, 2023
123739d
remove sanitize method name
hghaf099 Jan 23, 2023
1777888
guard a possbile nil ref
hghaf099 Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/18610.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
```release-note:improvement
auth: Allow naming login MFA methods and using those names instead of IDs in satisfying MFA requirement for requests.
Make passcode arguments consistent across login MFA method types.
```
3 changes: 3 additions & 0 deletions command/format.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,9 @@ func (t TableFormatter) OutputSecret(ui cli.Ui, secret *api.Secret) error {
for _, constraint := range constraintSet.Any {
out = append(out, fmt.Sprintf("mfa_constraint_%s_%s_id %s %s", k, constraint.Type, hopeDelim, constraint.ID))
out = append(out, fmt.Sprintf("mfa_constraint_%s_%s_uses_passcode %s %t", k, constraint.Type, hopeDelim, constraint.UsesPasscode))
if constraint.Name != "" {
out = append(out, fmt.Sprintf("mfa_constraint_%s_%s_name %s %s", k, constraint.Type, hopeDelim, constraint.Name))
mpalmi marked this conversation as resolved.
Show resolved Hide resolved
}
}
}
} else { // Token information only makes sense if no further MFA requirement (i.e. if we actually have a token)
Expand Down
Loading