Account for mount counts when de-duplicating current and historical month data #18598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ccapurso
approved these changes
Jan 5, 2023
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
…onth data (#18598) * Account for mount counts when de-duplicating current and historical month data * add changelog
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
…onth data (#18598) * Account for mount counts when de-duplicating current and historical month data * add changelog
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #18452 I failed to account for mount counts, which meant that when you did a CSV export in the UI, while the total was correct, if you added up all the totals for all the mounts, it fell short of the total by the exact amount from the current month data. This corrects that oversight. It would be super awesome to get some tests around all this stuff at some point but the current unit tests for this section of the code are a bit rough. I'm not sure if we want to hold up this PR for adding them, or add them at a later date.