-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MongoDB - Fix write_concern param #18546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swenson
approved these changes
Dec 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vinay-gopalan
approved these changes
Dec 23, 2022
austingebauer
approved these changes
Dec 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should backport this as well. Thanks, @MilenaHC 👍
This was referenced Dec 23, 2022
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
* fix writeconcern defaulting to majority * add changelog * restart CI tests * fix tests * add package
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
* fix writeconcern defaulting to majority * add changelog * restart CI tests * fix tests * add package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Vault deletes a user on a MongoDB replica, it always uses
WriteConcern = 'majority'
despite the setting in the connection configuration.Results from the log without the fix using
write_concern="{\"W\": 1}"
:Results from the log with the fix using
write_concern="{\"W\": 1}"
: