Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VAULT-12112: add openapi response structures for /sys/config and /sys/generate-root endpoints #18472

Merged
merged 8 commits into from
Feb 16, 2023
Merged

VAULT-12112: add openapi response structures for /sys/config and /sys/generate-root endpoints #18472

merged 8 commits into from
Feb 16, 2023

Conversation

dhuckins
Copy link
Contributor

@dhuckins dhuckins commented Dec 19, 2022 •
edited
Loading

Path Operation response notes
/sys/config/cors READ link
/sys/config/cors UPDATE link
/sys/config/cors DELETE link
/sys/config/state/sanitized READ link no references found in tests
/sys/config/reload/{subsystem} UPDATE link no references found in tests
/sys/config/ui/headers/{header} READ link
/sys/config/ui/headers/{header} UPDATE link
/sys/config/ui/headers/{header} DELETE link
/sys/config/ui/headers/ LIST link
/sys/generate-root READ link no references found in tests
/sys/generate-root/attempt READ link no references found in tests
/sys/generate-root UPDATE link no references found in tests
/sys/generate-root/attempt UPDATE link no references found in tests
/sys/generate-root DELETE link no references found in tests
/sys/generate-root/attempt DELETE link no references found in tests
/sys/generate-root/update UPDATE link no references found in tests

@dhuckins
some config responses
d0c0a30 
Signed-off-by: Daniel Huckins <[email protected]>
@dhuckins
added response structs
5f9d2cb 
Signed-off-by: Daniel Huckins <[email protected]>
@dhuckins dhuckins added this to the 1.13.0-rc1 milestone Dec 22, 2022
@dhuckins dhuckins changed the base branch from dh/response-structures-sys-1 to main December 22, 2022 19:48
@dhuckins dhuckins marked this pull request as ready for review December 22, 2022 19:49
@dhuckins dhuckins changed the title dh/response structures sys 1 config add openapi response structures for /sys/config and /sys/generate-root endpoints Dec 23, 2022
averche
averche approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me, though I only spot checked some responses.

@dhuckins dhuckins changed the title add openapi response structures for /sys/config and /sys/generate-root endpoints VAULT-12112: add openapi response structures for /sys/config and /sys/generate-root endpoints Jan 5, 2023
@averche averche modified the milestones: 1.13.0-rc1, 1.14 Feb 13, 2023
@dhuckins dhuckins merged commit 5421b9f into main Feb 16, 2023
@dhuckins dhuckins deleted the dh/response-structures-sys-1-config branch February 16, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averche averche averche approved these changes

@lursu lursu Awaiting requested review from lursu

@AnPucel AnPucel Awaiting requested review from AnPucel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
2 participants
@dhuckins @averche