Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vault 11796 vault cli list intermediates #18463

Merged
merged 24 commits into from
Jan 27, 2023
Merged

Vault 11796 vault cli list intermediates #18463

merged 24 commits into from
Jan 27, 2023

Conversation

kitography
Copy link
Contributor

@kitography kitography commented Dec 19, 2022 •
edited
Loading

This addes the list-intermediate command to the vault pki client.

@cipherboy cipherboy requested review from cipherboy, stevendpclark and a team December 19, 2022 14:33
@cipherboy cipherboy added this to the 1.13.0-rc1 milestone Dec 19, 2022
@kitography kitography changed the base branch from main to VAULT-11795-vault-cli-verify-s-ign December 19, 2022 21:28
stevendpclark
stevendpclark reviewed Jan 4, 2023
View reviewed changes
command/pki_list_children_command.go Outdated Show resolved Hide resolved
command/pki_list_children_command.go Outdated Show resolved Hide resolved
command/pki_list_children_command.go Outdated Show resolved Hide resolved
cipherboy
cipherboy reviewed Jan 26, 2023
View reviewed changes
changelog/18463.txt Outdated Show resolved Hide resolved
@kitography kitography changed the base branch from VAULT-11795-vault-cli-verify-s-ign to main January 27, 2023 13:57
@kitography kitography enabled auto-merge (squash) January 27, 2023 14:41
cipherboy
cipherboy approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@cipherboy cipherboy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, but would be good to get Steve's eyes too.

Edit: whoops, missed the auto-merge :D

@kitography kitography merged commit 416f8bd into main Jan 27, 2023
@kitography
Copy link
Contributor Author

(You are welcome to make comments now @stevendpclark , and i'll definitely create another PR)

stevendpclark
stevendpclark reviewed Jan 27, 2023
View reviewed changes
Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little late coming back to this but 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendpclark stevendpclark stevendpclark left review comments

@cipherboy cipherboy cipherboy approved these changes

Assignees
No one assigned
Labels
enhancement secret/pki
Projects
None yet
Milestone
1.13.0-rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@kitography @cipherboy @stevendpclark