Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VAULT-12112: openapi response definitions: sys/audit #18456

Merged
merged 8 commits into from
Jan 20, 2023
Merged

VAULT-12112: openapi response definitions: sys/audit #18456

merged 8 commits into from
Jan 20, 2023

Conversation

dhuckins
Copy link
Contributor

@dhuckins dhuckins commented Dec 16, 2022 •
edited
Loading

Path Operation response docs
/sys/audit-hash/{path} UPDATE link docs
/sys/audit READ link docs
/sys/audit/{path} UPDATE link docs
/sys/audit/{path} DELETE link docs
/sys/config/auditing/request-headers READ link docs
/sys/config/auditing/request-headers/{header} UPDATE link docs
/sys/config/auditing/request-headers/{header} DELETE link docs
/sys/config/auditing/request-headers/{header} READ link docs

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 16, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dhuckins dhuckins changed the base branch from main to dh/response-structures-sys-1 December 16, 2022 23:25
@dhuckins dhuckins added this to the 1.13.0-rc1 milestone Dec 22, 2022
@dhuckins dhuckins marked this pull request as ready for review December 22, 2022 18:34
@dhuckins dhuckins marked this pull request as draft December 22, 2022 18:35
@dhuckins dhuckins marked this pull request as ready for review December 22, 2022 19:31
@dhuckins dhuckins changed the base branch from dh/response-structures-sys-1 to main December 22, 2022 19:48
averche
averche approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the detailed description!

@dhuckins dhuckins changed the title openapi response definitions: sys/audit VAULT-12112: openapi response definitions: sys/audit Jan 5, 2023
@dhuckins dhuckins requested a review from a team January 19, 2023 19:17
@dhuckins dhuckins requested review from a team, fairclothjm and tjperry07 as code owners January 19, 2023 19:17
@dhuckins dhuckins requested a review from a team January 19, 2023 19:17
@dhuckins dhuckins force-pushed the dh/response-structures-sys-1-audit branch from c837e26 to 544ddf8 Compare January 19, 2023 19:44
@dhuckins dhuckins removed request for a team, tjperry07 and fairclothjm January 19, 2023 20:49
@averche averche force-pushed the dh/response-structures-sys-1-audit branch from 8396e8f to baffe55 Compare January 19, 2023 20:53
averche
averche approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dhuckins dhuckins merged commit 94d0ba0 into main Jan 20, 2023
@dhuckins dhuckins deleted the dh/response-structures-sys-1-audit branch January 20, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averche averche averche approved these changes

@lursu lursu Awaiting requested review from lursu

@AnPucel AnPucel Awaiting requested review from AnPucel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.0-rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@dhuckins @hashicorp-cla @averche