UI: PKI stub configure page #18349
Merged
UI: PKI stub configure page #18349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hashishaw
commented
Dec 13, 2022
•
hashishaw
commented
- Check for PKI config on overview page and show empty state if no config
- Stub configuration landing page (each form is a separate ticket)
hashishaw
commented
Dec 13, 2022
| @@ -3,6 +3,7 @@ import buildRoutes from 'ember-engines/routes'; | |||
| export default buildRoutes(function () { | |||
| this.route('overview'); | |||
| this.route('configuration', function () { | |||
| this.route('index', { path: '/' }); | |||
There was a problem hiding this comment.
Added this route so that the "read configuration" contents don't render on child paths
kiannaquach
reviewed
Dec 13, 2022
kiannaquach
reviewed
Dec 13, 2022
| if (model) { | ||
| return model.get('firstObject'); | ||
| } | ||
| }), |
There was a problem hiding this comment.
I'm not sure if you need this, but since this is in a hash you may need a catch statement if any promises fail
There was a problem hiding this comment.
If it fails the page will load the error state, which is what we want
kiannaquach
reviewed
Dec 13, 2022
divyaac
pushed a commit
that referenced
this pull request
Dec 14, 2022
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.