-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server: add and support unix listener (UDS) #18227
Conversation
68ad0bf
to
42aad53
Compare
@raskchanky PTAL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I think it looks great and would love to get it merged. Before doing so though, I think we need some documentation. Would you be up for writing some docs for this change? Specifically:
- https://developer.hashicorp.com/vault/docs/configuration/listener should mention there's now multiple listener types and should link to a new page for the UDS listener, similar to the TCP one.
- A new page, similar to https://developer.hashicorp.com/vault/docs/configuration/listener/tcp but obviously less involved, mentioning what a Unix domain socket is, the available listener parameters that can be configured, and a few code examples. I also think your example showing how to connect to Vault over a UDS with curl would be an excellent addition.
If you've never written Vault docs before, the website README has docs that show how to run the site locally via docker.
Someone is attempting to deploy a commit to the HashiCorp Team on Vercel. A member of the Team first needs to authorize it. |
@raskchanky Website and docs have been updated as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation looks great! Thanks for writing it up. I left a bunch of minor copy edits.
@raskchanky fantastic, the typo removed and docs updated per your suggestion 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just merge the unix and definition changes and it's good to go
@raskchanky @tjperry07 PTAL, docs updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for your great contribution!
Co-authored-by: shaj13 <[email protected]>
Fix #5491
hcl config
Vault server logs:
Curl Example