Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Address a nil panic when writing an empty POST request to the ocsp handler into release/1.12.x #18187

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #18184 to be assessed for backporting due to the inclusion of the label backport/1.12.x.

The below text is copied from the body of the original PR.


Identified by @cipherboy thanks!

  • Seems when no body is sent with a POST request Vault will not populate the HTTPRequest member variable which causes a nil panic, it can be reproduced with vault write -force pki/ocsp
  • Add a check for it and the Body member variable to be nil before use.

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/stevendpclark/fix-ocsp-panic-on-nil-request/virtually-actual-kingfish branch 2 times, most recently from 18182d4 to 1d2fada Compare December 1, 2022 15:10
@stevendpclark stevendpclark self-assigned this Dec 1, 2022
@stevendpclark stevendpclark enabled auto-merge (squash) December 1, 2022 15:12
@stevendpclark stevendpclark added this to the 1.12.3 milestone Dec 1, 2022
…nic-on-nil-request/virtually-actual-kingfish
@stevendpclark stevendpclark merged commit 1b9fed9 into release/1.12.x Dec 1, 2022
@stevendpclark stevendpclark deleted the backport/stevendpclark/fix-ocsp-panic-on-nil-request/virtually-actual-kingfish branch December 1, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants