Skip Formatting For NIL Secret

[ltcarbonell]

Vault is currently panicking when trying to patch with the -field parameter set. This occurs because we are expecting there to be metadata around the secret, but none is getting returned due to the flag being set. A check has been added to ensure that the secret is populated before trying to access the Data from underneath it.

Previous Error:

$ vault kv patch -field=version  -method=rw -mount=kv /secrets test=- <<< "new"
4
= Secret Path =
kv/data/secrets

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x30 pc=0x103aeab1c]

goroutine 1 [running]:
github.com/hashicorp/vault/command.(*KVPatchCommand).Run(0x14000aca440, {0x140001a0030, 0x5, 0x5})
	/Users/runner/work/vault/vault/command/kv_patch.go:232 +0x3fc
github.com/mitchellh/cli.(*CLI).Run(0x1400062edc0)
	/Users/runner/go/pkg/mod/github.com/mitchellh/[email protected]/cli.go:262 +0x4a8
github.com/hashicorp/vault/command.RunCustom({0x140001a0010?, 0x7?, 0x7?}, 0x140000021a0?)
 	/Users/runner/work/vault/vault/command/main.go:237 +0x930
github.com/hashicorp/vault/command.Run(...)
	/Users/runner/work/vault/vault/command/main.go:142
main.main()
	/Users/runner/work/vault/vault/main.go:10 +0x54

After change:

$ vault kv patch -field=version  -method=rw -mount=kv /secrets test=- <<< "new2"     
10
= Secret Path =
kv/data/secrets

UPDATE:
updated output

$ vault kv put secret/test foo=bar3               
== Secret Path ==
secret/data/test
 
======= Metadata =======
Key                Value
---                -----
created_time       2022-12-01T16:03:45.398495Z
custom_metadata    <nil>
deletion_time      n/a
destroyed          false
version            8

$ vault kv put -field=version secret/test foo=bar3
9

$ vault kv patch -field=version secret/test foo=bar4
10

$ vault kv patch  secret/test foo=bar4 
== Secret Path ==
secret/data/test

======= Metadata =======
Key                Value
---                -----
created_time       2022-12-01T16:04:59.014316Z
custom_metadata    <nil>
deletion_time      n/a
destroyed          false
version            11

[averche]

LGTM

[davidadeleon]

While this does address the panic, I do wonder if we want to continue displaying the secret path helper text when the field flag is provided? The behavior from this change doesn't match the behavior of other KV commands like kv get or kv put where we don't print that information.

Ex:

❯ vault kv put secret/test foo=bar3
== Secret Path ==
secret/data/test

======= Metadata =======
Key                Value
---                -----
created_time       2022-11-30T19:22:20.217002Z
custom_metadata    <nil>
deletion_time      n/a
destroyed          false
version            5
❯ vault kv put -field=version secret/test foo=bar4
6

[ltcarbonell]

While this does address the panic, I do wonder if we want to continue displaying the secret path helper text when the field flag is provided? The behavior from this change doesn't match the behavior of other KV commands like kv get or kv put where we don't print that information.

Ex:

❯ vault kv put secret/test foo=bar3
== Secret Path ==
secret/data/test

======= Metadata =======
Key                Value
---                -----
created_time       2022-11-30T19:22:20.217002Z
custom_metadata    <nil>
deletion_time      n/a
destroyed          false
version            5
❯ vault kv put -field=version secret/test foo=bar4
6

Thats a good point. Especially if the expectation is that this result will be piped into other commands, the extra information might do more harm than good. I will update.

[davidadeleon]

LGTM!