UI: Pki engine (redesign) routing changes #17997
Conversation
| @@ -20,7 +20,7 @@ const KEY_BITS_OPTIONS = { | |||
| any: [0], | |||
| }; | |||
|
|
|||
| export default class KeyParameters extends Component { | |||
| export default class PkiKeyParameters extends Component { | |||
There was a problem hiding this comment.
@hashishaw and I had discussed nesting these components in a pki/ folder so that there weren't any conflicts with the addon engine. But for some reason the role form had trouble finding <Pki::KeyParameters> so I opted for prefixing the files with pki- instead
| this.route('generate-root'); | ||
| this.route('generate-csr'); | ||
| }); | ||
| this.route('create'); |
There was a problem hiding this comment.
The initial configuration has three radio buttons that provide a different configuration view, but they are all the same route. Instead of them each being separate routes, different components will render based on the user's selection
| this.route('edit'); | ||
| this.route('details'); |
There was a problem hiding this comment.
the config details will instead live at pki/configuration
| this.route('details'); | ||
| this.route('edit'); | ||
| }); | ||
| }); | ||
| this.route('keys', function () { | ||
| this.route('index', { path: '/' }); | ||
| this.route('generate'); | ||
| this.route('create'); |
There was a problem hiding this comment.
opted for create over generate to align with standard CRUD operation verbs
| @@ -0,0 +1,2 @@ | |||
| {{! https://github.com/hashicorp/vault/blob/main/website/content/api-docs/secret/pki.mdx#import-ca-certificates-and-keys }} | |||
There was a problem hiding this comment.
Ooooh the documentation right in the route stub! I love it!
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| </FormField> | ||
| {{/each}} | ||
| {{else if (eq group "Key usage")}} | ||
| <KeyUsage @model={{@model}} @group={{group}} /> | ||
| <PkiKeyUsage @model={{@model}} @group={{group}} /> |
Check warning
Code scanning / Semgrep Scanner
Detected a unquoted template variable as an attribute. If unquoted, a malicious actor could inject custom JavaScript handlers. To fix this, add quotes around the template expression, like this: "{{ expr }}".
| </FormField> | ||
| {{/each}} | ||
| {{else if (eq group "Key usage")}} | ||
| <KeyUsage @model={{@model}} @group={{group}} /> | ||
| <PkiKeyUsage @model={{@model}} @group={{group}} /> |
Check warning
Code scanning / Semgrep Scanner
Detected a unquoted template variable as an attribute. If unquoted, a malicious actor could inject custom JavaScript handlers. To fix this, add quotes around the template expression, like this: "{{ expr }}".
| {{else if (eq group "Key parameters")}} | ||
| <KeyParameters @model={{@model}} @group={{group}} /> | ||
| <PkiKeyParameters @model={{@model}} @group={{group}} /> |
Check warning
Code scanning / Semgrep Scanner
Detected a unquoted template variable as an attribute. If unquoted, a malicious actor could inject custom JavaScript handlers. To fix this, add quotes around the template expression, like this: "{{ expr }}".
| {{else if (eq group "Key parameters")}} | ||
| <KeyParameters @model={{@model}} @group={{group}} /> | ||
| <PkiKeyParameters @model={{@model}} @group={{group}} /> |
Check warning
Code scanning / Semgrep Scanner
Detected a unquoted template variable as an attribute. If unquoted, a malicious actor could inject custom JavaScript handlers. To fix this, add quotes around the template expression, like this: "{{ expr }}".
| <nav class="box menu" aria-label="generate options"> | ||
| <ul class="menu-list"> | ||
| <li class="action"> | ||
| <LinkTo @route="configuration.create.generate-root" {{on "click" (fn this.onLinkClick D)}}> | ||
| <LinkTo @route="issuers.generate-root" {{on "click" (fn this.onLinkClick D)}}> |
Check warning
Code scanning / Semgrep Scanner
Detected a unquoted template variable as an attribute. If unquoted, a malicious actor could inject custom JavaScript handlers. To fix this, add quotes around the template expression, like this: "{{ expr }}".
| Root | ||
| </LinkTo> | ||
| </li> | ||
| <li class="action"> | ||
| <LinkTo @route="configuration.create.generate-csr" {{on "click" (fn this.onLinkClick D)}}> | ||
| <LinkTo @route="issuers.generate-intermediate" {{on "click" (fn this.onLinkClick D)}}> |
Check warning
Code scanning / Semgrep Scanner
Detected a unquoted template variable as an attribute. If unquoted, a malicious actor could inject custom JavaScript handlers. To fix this, add quotes around the template expression, like this: "{{ expr }}".
No description provided.