Deduplicate policies prior to generating ACL on request #17914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpalmi
reviewed
Nov 11, 2022
jasonodonnell
approved these changes
Nov 14, 2022
hghaf099
approved these changes
Nov 14, 2022
|
This PR probably needs to get backported to previous versions. |
|
Also, I am wondering if we could go back to 1.10, and before the fix for that escalation. Apply this change, and see if we could reproduce the escalated issue. It would be a good test IMHO. |
ncabatoff
reviewed
Nov 16, 2022
ncabatoff
approved these changes
Nov 16, 2022
davidadeleon
deleted the
davidadeleon/fix-duplicate-policies-with-external-groups
branch
This was referenced Nov 16, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves an issue where a token can have duplicate policies as part of its policy set when using external groups. This scenario is encountered when an external group policy mapping is created in Vault containing duplicate policies to those defined by the authentication method.