Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes Secrets Engine #17893

Merged
merged 29 commits into from
Jan 18, 2023
Merged

Kubernetes Secrets Engine #17893

merged 29 commits into from
Jan 18, 2023

Conversation

zofskeez
Copy link
Contributor

@zofskeez zofskeez commented Nov 10, 2022

Adds Kubernetes as supported secrets engine.
image
image
image

* adds in-repo ember engine for kubernetes secrets engine

* updates kubernetes engine class name
* kubernetes route plumbing

* adds kubernetes role index route with redirect to details
* moves RadioCard component to core addon

* adds kubernetes configuration view

* fixes tests using RadioCard after label for and input id changes

* adds confirm modal when editing kubernetes config

* addresses review comments
* removes configuration edit and index routes

* adds kubernetes configuration view
* removes configuration edit and index routes

* adds kubernetes configuration view

* adds kubernetes secrets engine roles list view

* updates role details disabled state to explicitly check for false
@vercel
Copy link

vercel bot commented Dec 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
vault ⬜️ Ignored (Inspect) Dec 6, 2022 at 6:54PM (UTC)

kiannaquach and others added 8 commits December 6, 2022 10:54
* Add overview page view

* Add overview page tests

* Address feedback to update tests and minor changes

* Use template built in helper for conditionally showing num roles

* Set up roleOptions in constructor

* Set up models in tests and fix minor bug
* moves kv-object-editor to core addon

* moves json-editor to core addon

* adds kubernetes secrets engine create/edit views

* updates kubernetes/role adapter test

* addresses feedback
* moves format-duration helper to core addon

* adds kubernetes secrets engine role details view

* adds tests for role details page component

* adds capabilities checks for toolbar actions
* updates overview, configuration and roles components to pass args for individual model properties

* bug fixes and improvements

* adds top level index route to redirect to overview
* Add credentials route with create and view components

* Update mirage response for creds and add ajax post call for creds in adapter

* Move credentials create and view into one component

* Add test classes

* Remove files and update backend property name

* Code cleanup and add tests

* Put test helper in helper function

* Add one more test!

* Add code optimizations

* Fix model in route and add form

* Add onSubmit to form and preventDefault

* Fix tests

* Update mock data for test to be strong rather than record
zofskeez and others added 5 commits December 14, 2022 08:26
* VAULT-12185 overview acceptance tests

* VAULT-12298 credentials acceptance tests

* VAULT-12186 configuration acceptance tests
* VAULT-12127 Refactor breadcrumbs to use Page::Breadcrumbs component

* Fix failing tests by adding breadcrumbs properties
@zofskeez zofskeez marked this pull request as ready for review January 5, 2023 17:37
@zofskeez zofskeez enabled auto-merge (squash) January 18, 2023 20:51
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@zofskeez zofskeez merged commit 44a8e1b into main Jan 18, 2023
@zofskeez zofskeez deleted the ui/kubernetes-secrets-engine branch January 18, 2023 21:03
@@ -0,0 +1,3 @@
```release-note:feature
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zofskeez - Could you please open a PR to change this to the formatting for the "features" section of the changelog? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mladlow oops I missed that in the readme! Sorry about that. #19062 updates the formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants