Backport of Optional automatic default issuer selection into release/1.12.x #17854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/cipherboy-automatic-default-issuer/firstly-vast-tapir
branch
from
96e6d5c to
eebd435
Compare
cipherboy
approved these changes
Nov 8, 2022
cipherboy
added a commit
that referenced
this pull request
Nov 9, 2022
Co-authored-by: Alexander Scheel <[email protected]> Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
added a commit
that referenced
this pull request
Nov 9, 2022
Co-authored-by: Alexander Scheel <[email protected]> Co-authored-by: Alexander Scheel <[email protected]>
cipherboy
deleted the
backport/cipherboy-automatic-default-issuer/firstly-vast-tapir
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17824 to be assessed for backporting due to the inclusion of the label backport/1.12.x.
The below text is copied from the body of the original PR.
When attempting compatibility against multiple versions of Vault, one major breaking change in Vault 1.11 was the multiple issuer's functionality and behavior changes around importing issuers (wherein
/config/carequired a deletion first) and generation of new issuers (where both root/intermediate generation silently removed old keys!).While we don't wish to remove key material any more, thus becoming more safe, the net was a breaking change across APIs: because the default issuer was not updated on these operations, the issuer would appear "lost" to any callers. Only when an operator updated the default issuer would non-multi-issuer aware applications see this new CA.
However, not everyone will want to automatically change the default issuer: for applications and operators aware of multi-issuer functionality, who wish to proactively prime new isseurs prior to enabling them (perhaps for distribution purposes), this change shouldn't be automatic and retroactive.
Thus, make this an opt-in change on
/config/issuers.This obviously needs:
Like #17823, I'm curious to get people's thoughts.
Overview of commits