Backport of OIDC Alternate Path Bug into release/1.11.x #17683
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17661 to be assessed for backporting due to the inclusion of the label backport/1.11.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
This PR addresses issues with error handling within the OIDC login workflow and fixes a bug with the inputted role not being retained when attempting to login at an alternate mount path. This was brought up in issue #14671 where it was also pointed out that logging in with the jwt auth method using the mount tabs was returning an error which has also been fixed.
Alternate mount path issue as observed in 1.12.0:
After clicking the sign in button numerous times it appears that nothing happens, when in reality the
role
is not passed in the request for theauth_url
and the check for that returns out of the function without any communication to the user.After updates:
The
foo
role doesn't exist for thefoo-oidc
path and now an error is displayed. Next, thebar
role does not have aredirect_uri
for the pathfoo-oidc
. Once theauth_url
is available we can now login as expected.Overview of commits