Add Paging Interface for LDAP Connection #17640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonodonnell
requested review from
austingebauer,
swenson,
fairclothjm,
Zlaticanin,
robmonte,
calvn and
maxcoulombe
austingebauer
approved these changes
Oct 24, 2022
@austingebauer unfortunately no, my machine wasn't a fan of that many groups 😆. I did set it arbitrarily low to make sure that it would work if groups were larger than the page size. |
fairclothjm
approved these changes
Oct 25, 2022
ltcarbonell
force-pushed
the
ldap-paging-search
branch
2 times, most recently
from
b1fdf6a to
dbc068a
Compare
ltcarbonell
force-pushed
the
ldap-paging-search
branch
from
dbc068a to
a677bbe
Compare
ltcarbonell
force-pushed
the
ldap-paging-search
branch
from
a677bbe to
57aca42
Compare
This appears to be due to a CI change that resulted in different user IDs between the host and the container image. Signed-off-by: Alexander Scheel <[email protected]> Signed-off-by: Alexander Scheel <[email protected]>
This was referenced Oct 26, 2022
This was referenced Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vault was returning the following error when trying to filter on a large number of groups
This change makes use of paginated ldap searching, through a new connection interface as to maintain backwards compatibility for the SDK.
Fixes #7702