Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intercept key_id from generic configmap and turn it into a wrapperv2 option #17612

Merged
merged 4 commits into from
Oct 19, 2022

Conversation

sgmiller
Copy link
Collaborator

Wrapper v2 has a dedicated option for KeyID. But we handle seal config
generically. We need to catch this in the config map and convert it to the
new option.

@sgmiller sgmiller requested a review from a team October 19, 2022 19:08
Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something feels wrong, or I'm missing something...

Looking at the docs for seal configuration only OCI uses the key_id configuration field so why are we applying it to all the wrappers now? AliCloud and AWS both use kms_key_id which seem to be handled properly in the v2 code.

Technically this should be fixed within the ocikms.go I think but we could workaround it here as well to save from cutting a new version of go-kms-wrapping.

@sgmiller
Copy link
Collaborator Author

Something feels wrong, or I'm missing something...

Looking at the docs for seal configuration only OCI uses the key_id configuration field so why are we applying it to all the wrappers now? AliCloud and AWS both use kms_key_id which seem to be handled properly in the v2 code.

Technically this should be fixed within the ocikms.go I think but we could workaround it here as well to save from cutting a new version of go-kms-wrapping.

That's good to know, and explains why it hasn't tripped up more KMSes. I addressed it this way because of Wrapper v2 having a generic keyId property. Technically I could just put that in the switch statement for OCIKMS.

Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants