vault operator init -output-curl-string bug #17514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskchanky
approved these changes
Oct 12, 2022
|
Just realized that some other places that are handling this also do |
Yes, I ran a test with -output-policy i.e; vault operator init -format=json -key-shares 1 -key-threshold 1 -output-policy and it gives the output for sys/seal-status. I will add a fix for that. I am not sure if we need to worry about SetWrappingLookupFunction. |
mpalmi
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack: https://hashicorp.slack.com/archives/CMRSLF924/p1665566769095959
Bug:
vault operator init -key-shares=1 -key-threshold=1 -output-curl-string
curl -H "X-Vault-Request: true" -H "X-Vault-Token: $(vault print token)" http://127.0.0.1:8200/v1/sys/seal-status
Fix:
vault operator init -format=json -key-shares 1 -key-threshold 1 -output-curl-string
curl -X PUT -H "X-Vault-Request: true" -H "X-Vault-Token: $(vault print token)" -d '''{"secret_shares":1,"secret_threshold":1,"stored_shares":0,"pgp_keys":null,"recovery_shares":0,"recovery_threshold":0,"recovery_pgp_keys":null,"root_token_pgp_key":""}''' http://127.0.0.1:8200/v1/sys/init