Fix tidy-status, tidy-cancel on PR Secondaries #17497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
requested review from
victorr,
kitography,
stevendpclark and
a team
sgmiller
approved these changes
Oct 11, 2022
PKI's tidy-status included a bug that prevented PR secondary nodes from responding with the status of the running tidy operation: while the operation constructor correctly forwarded the node on PR standby instances, the handler itself forwarded also on PR secondary nodes. This is incorrect as the PR secondary nodes are the active node in the local PR cluster, and run tidy operations otherwise. This meant that while auto-tidy and tidy operations would run, there was no insight into the process. When implementing tidy-cancel, tidy-status's handler logic was reused, duplicating the bug there as well. Signed-off-by: Alexander Scheel <[email protected]>
Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
force-pushed
the
cipherboy-fix-tidy-run-on-nodes
branch
from
83fb094 to
9d82eab
Compare
stevendpclark
approved these changes
Oct 12, 2022
|
Thanks all, merged! |
This was referenced Oct 12, 2022
cipherboy
added a commit
that referenced
this pull request
Oct 12, 2022
* Fix tidy-status, tidy-cancel on PR Secondaries PKI's tidy-status included a bug that prevented PR secondary nodes from responding with the status of the running tidy operation: while the operation constructor correctly forwarded the node on PR standby instances, the handler itself forwarded also on PR secondary nodes. This is incorrect as the PR secondary nodes are the active node in the local PR cluster, and run tidy operations otherwise. This meant that while auto-tidy and tidy operations would run, there was no insight into the process. When implementing tidy-cancel, tidy-status's handler logic was reused, duplicating the bug there as well. Signed-off-by: Alexander Scheel <[email protected]> * Add changelog entry Signed-off-by: Alexander Scheel <[email protected]> Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
added a commit
that referenced
this pull request
Oct 12, 2022
* Fix tidy-status, tidy-cancel on PR Secondaries PKI's tidy-status included a bug that prevented PR secondary nodes from responding with the status of the running tidy operation: while the operation constructor correctly forwarded the node on PR standby instances, the handler itself forwarded also on PR secondary nodes. This is incorrect as the PR secondary nodes are the active node in the local PR cluster, and run tidy operations otherwise. This meant that while auto-tidy and tidy operations would run, there was no insight into the process. When implementing tidy-cancel, tidy-status's handler logic was reused, duplicating the bug there as well. Signed-off-by: Alexander Scheel <[email protected]> * Add changelog entry Signed-off-by: Alexander Scheel <[email protected]> Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
added a commit
that referenced
this pull request
Oct 12, 2022
* Fix tidy-status, tidy-cancel on PR Secondaries PKI's tidy-status included a bug that prevented PR secondary nodes from responding with the status of the running tidy operation: while the operation constructor correctly forwarded the node on PR standby instances, the handler itself forwarded also on PR secondary nodes. This is incorrect as the PR secondary nodes are the active node in the local PR cluster, and run tidy operations otherwise. This meant that while auto-tidy and tidy operations would run, there was no insight into the process. When implementing tidy-cancel, tidy-status's handler logic was reused, duplicating the bug there as well. Signed-off-by: Alexander Scheel <[email protected]> * Add changelog entry Signed-off-by: Alexander Scheel <[email protected]> Signed-off-by: Alexander Scheel <[email protected]> Signed-off-by: Alexander Scheel <[email protected]> Co-authored-by: Alexander Scheel <[email protected]>
cipherboy
added a commit
that referenced
this pull request
Oct 12, 2022
* Fix tidy-status, tidy-cancel on PR Secondaries PKI's tidy-status included a bug that prevented PR secondary nodes from responding with the status of the running tidy operation: while the operation constructor correctly forwarded the node on PR standby instances, the handler itself forwarded also on PR secondary nodes. This is incorrect as the PR secondary nodes are the active node in the local PR cluster, and run tidy operations otherwise. This meant that while auto-tidy and tidy operations would run, there was no insight into the process. When implementing tidy-cancel, tidy-status's handler logic was reused, duplicating the bug there as well. Signed-off-by: Alexander Scheel <[email protected]> * Add changelog entry Signed-off-by: Alexander Scheel <[email protected]> Signed-off-by: Alexander Scheel <[email protected]> Signed-off-by: Alexander Scheel <[email protected]> Co-authored-by: Alexander Scheel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PKI's tidy-status included a bug that prevented PR secondary nodes from responding with the status of the running tidy operation: while the operation constructor correctly forwarded the node on PR standby instances, the handler itself forwarded also on PR secondary nodes.
This is incorrect as the PR secondary nodes are the active node in the local PR cluster, and run tidy operations otherwise.
This meant that while auto-tidy and tidy operations would run, there was no insight into the process.
When implementing tidy-cancel, tidy-status's handler logic was reused, duplicating the bug there as well.
Signed-off-by: Alexander Scheel <[email protected]>