Updates/removes dependencies throwing errors in Ember 4.4 #17396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ince contains was removed
…sing params arg with LinkTo
…rop in same computation
zofskeez
commented
Oct 3, 2022
Comment on lines
+5
to
+6
| lastUpdateCheck 1664829239911 | ||
| yarn-path ".yarn/releases/yarn-1.22.19.js" |
There was a problem hiding this comment.
After updating ember-data to 4.5 an error was thrown stating that the yarn version was too old and the build failed. I ran yarn policies set-version 1.22.19 as per the readme to update the embedded yarn version to the latest.
zofskeez
commented
Oct 3, 2022
zofskeez
commented
Oct 3, 2022
zofskeez
commented
Oct 3, 2022
zofskeez
commented
Oct 3, 2022
zofskeez
commented
Oct 3, 2022
Comment on lines
+4
to
+6
| import IdentityManager from '../utils/identity-manager'; | ||
|
|
||
| const uuids = new IdentityManager(); |
There was a problem hiding this comment.
I was running into an issue where cluster_id was not defined and the replication attributes need a unique id or the store will throw an error so I adapted the mirage identity manager into a utility and use it here.
zofskeez
commented
Oct 3, 2022
zofskeez
commented
Oct 3, 2022
Comment on lines
+57
to
67
| return fields.map((field) => { | ||
| let meta = {}; | ||
| // check for relationship by presence of dot nation in field name | ||
| if (field.includes('.')) { | ||
| const [relKey, prop] = field.split('.'); | ||
| const rel = modelClass.belongsTo(relKey); | ||
| const relModelClass = modelClass.store.modelFor(rel.type); | ||
| meta = getAttributeMeta(relModelClass, prop); | ||
| } else { | ||
| meta = getAttributeMeta(modelClass, field); | ||
| } |
There was a problem hiding this comment.
This looks up the model for the relationship and then calls eachAttribute to get the meta data.
zofskeez
commented
Oct 3, 2022
zofskeez
commented
Oct 3, 2022
Comment on lines
-40
to
+44
| this.toList(); | ||
| this.addInput(); | ||
| next(() => { | ||
| this.toList(); | ||
| this.addInput(); | ||
| }); |
There was a problem hiding this comment.
This was throwing an error about modifying twice in the same computation and preventing the view from loading so I used next to work around it.
zofskeez
commented
Oct 3, 2022
| "ember-copy": "2.0.1", | ||
| "ember-d3": "^0.5.1", | ||
| "ember-data": "~4.4.0", | ||
| "ember-data-model-fragments": "5.0.0-beta.5", | ||
| "ember-data": "~4.5.0", |
There was a problem hiding this comment.
I ran into an issue where an error was thrown when doing yield model.save(); in a concurrency task which prompted the bump to 4.5.
hellobontempo
approved these changes
Oct 4, 2022
zofskeez
added a commit
that referenced
this pull request
Oct 18, 2022
* runs ember-cli-update to 4.4.0 * updates yarn.lock * updates dependencies causing runtime errors (#17135) * Inject Store Service When Accessed Implicitly (#17345) * adds codemod for injecting store service * adds custom babylon parser with decorators-legacy plugin for jscodeshift transforms * updates inject-store-service codemod to only look for .extend object expressions and adds recast options * runs inject-store-service codemod on js files * replace query-params helper with hash (#17404) * Updates/removes dependencies throwing errors in Ember 4.4 (#17396) * updates ember-responsive to latest * updates ember-composable-helpers to latest and uses includes helper since contains was removed * updates ember-concurrency to latest * updates ember-cli-clipboard to latest * temporary workaround for toolbar-link component throwing errors for using params arg with LinkTo * adds missing store injection to auth configure route * fixes issue with string-list component throwing error for accessing prop in same computation * fixes non-iterable query params issue in mfa methods controller * refactors field-to-attrs to handle belongsTo rather than fragments * converts mount-config fragment to belongsTo on auth-method model * removes ember-api-actions and adds tune method to auth-method adapter * converts cluster replication attributes from fragment to relationship * updates ember-data, removes ember-data-fragments and updates yarn to latest * removes fragments from secret-engine model * removes fragment from test-form-model * removes commented out code * minor change to inject-store-service codemod and runs again on js files * Remove LinkTo positional params (#17421) * updates ember-cli-page-object to latest version * update toolbar-link to support link-to args and not positional params * adds replace arg to toolbar-link component * Clean up js lint errors (#17426) * replaces assert.equal to assert.strictEqual * update eslint no-console to error and disables invididual intended uses of console * cleans up hbs lint warnings (#17432) * Upgrade bug and test fixes (#17500) * updates inject-service codemod to take arg for service name and runs for flashMessages service * fixes hbs lint error after merging main * fixes flash messages * updates more deps * bug fixes * test fixes * updates ember-cli-content-security-policy and prevents default form submission throwing errors * more bug and test fixes * removes commented out code * fixes issue with code-mirror modifier sending change event on setup causing same computation error * Upgrade Clean Up (#17543) * updates deprecation workflow and filter * cleans up build errors, removes unused ivy-codemirror and sass and updates ember-cli-sass and node-sass to latest * fixes control groups test that was skipped after upgrade * updates control group service tests * addresses review feedback * updates control group service handleError method to use router.currentURL rather that transition.intent.url * adds changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates any dependencies that were throwing errors after the upgrade to Ember 4.4 and removes
ember-data-fragments. For the most part the fragments were converted to regular models and defined as abelongsTorelationship on the parent models. Thefields-to-attrsutil was refactored to expand the attribute meta data for relationships rather than fragments and the serializers were updated to use theEmbeddedRecordMixin.