-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli/api: Update plugin listing to always include version info in the response #17347
Conversation
93b0225
to
cf76ca3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work for me, though I am noticing that vault plugin list secret
output is not sorted by name, while vault plugin list auth
is (whether -detailed
is supplied or not).
Good spot! There was a silly sorting bug which I've fixed in 1c6a3d1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this test needs to be updated, but otherwise 👍
vault/command/plugin_list_test.go
Lines 36 to 42 in f4b05c4
{ | |
"lists", | |
nil, | |
"Plugins", | |
0, | |
}, | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Should we update the docs to show the new output?
Thanks for the reminder! Done in bfab936 |
I found an issue where
vault plugin list -detailed auth
returned an empty response. There was also a small bug in theapi
package's JSON tags that stoppedtype
getting populated in details.api: Updated the typed call to always use the untyped API so that it can always include the extra details like version etc.
cli: Added
detailed
key to JSON output, and type/version to non-detailed output because a plugin name on its own is not enough to specify a plugin, so it's not very informative to just list the names.New output: