Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of auth/token: Fix ignored parameter warnings for valid parameters on token create into release/1.10.x #16976

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16938 to be assessed for backporting due to the inclusion of the label backport/1.10.x.

The below text is copied from the body of the original PR.


This PR fixes a bug where a user would receive a warning that the endpoint ignored unrecognized parameters, when those parameters are in fact recognized and expected when calling vault token create in the CLI or the equivalent API call:

❯ ./vault token create -explicit-max-ttl="10m" -policy="default"
WARNING! The following warnings were returned from Vault:

  * TTL of "768h" exceeded the effective max_ttl of "10m"; TTL value is capped
  accordingly

  * Endpoint ignored these unrecognized parameters: [display_name entity_alias
  explicit_max_ttl num_uses period policies renewable ttl type]

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/davidadeleon/fix-ingored-parameter-warning-token-create/readily-calm-grouse branch from 1646ea3 to fd9e6a6 Compare September 1, 2022 12:33
…parameter-warning-token-create/readily-calm-grouse
@jasonodonnell jasonodonnell added this to the 1.10.10 milestone Jan 6, 2023
@maxb
Copy link
Contributor

maxb commented Jan 6, 2023

This PR is an incremental improvement, and my comment is not meant to delay it - but some of the parameters being backported here are incorrect and I have submitted PR #18556 making further improvements to the token create parameter handling. If you're interested in this topic, you might be interested in those other changes too.

@jasonodonnell jasonodonnell merged commit 9451b65 into release/1.10.x Jan 6, 2023
@jasonodonnell jasonodonnell deleted the backport/davidadeleon/fix-ingored-parameter-warning-token-create/readily-calm-grouse branch January 9, 2023 14:19
@mladlow mladlow modified the milestones: 1.10.10, 1.10.11 Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants