Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCP link integration #16939

Merged
merged 8 commits into from
Sep 6, 2022
Merged

HCP link integration #16939

merged 8 commits into from
Sep 6, 2022

Conversation

hghaf099
Copy link
Contributor

@hghaf099 hghaf099 commented Aug 30, 2022 •
edited
Loading

Addresses VAULT-7893

@hghaf099 hghaf099 requested a review from ccapurso August 30, 2022 18:07
ccapurso
ccapurso approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but otherwise looks good to me!

command/server/test-fixtures/hcp_link_config.hcl Outdated Show resolved Hide resolved
ccapurso
ccapurso approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@hghaf099 hghaf099 merged commit 89f08de into main Sep 6, 2022
@mpalmi mpalmi mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccapurso ccapurso ccapurso approved these changes

Assignees
No one assigned
Labels
pr/no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hghaf099 @ccapurso