command/debug: fix bug where monitor was not honoring configured duration #16834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidadeleon
requested review from
raskchanky,
troyready,
briankassouf and
jasonodonnell
jasonodonnell
changed the title
jasonodonnell
approved these changes
Aug 23, 2022
raskchanky
approved these changes
Aug 23, 2022
This was referenced Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the log target for vault debug. When defining a debug duration length longer than two minutes, the vault.log file in the debug package would only have the first two minutes of logs emitted during the window, and then have newlines for the remainder of the time frame.