Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LIST issuers endpoint #16830

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Fix LIST issuers endpoint #16830

merged 2 commits into from
Aug 23, 2022

Conversation

kitography
Copy link
Contributor

@kitography kitography commented Aug 23, 2022 •
edited
Loading

Fixes an issue where the LIST endpoint required authentication.

@kitography kitography marked this pull request as ready for review August 23, 2022 14:40
cipherboy
cipherboy approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the thorough testing earlier!

@cipherboy cipherboy added bug Used to indicate a potential bug secret/pki labels Aug 23, 2022
@cipherboy cipherboy added this to the 1.12.0-rc1 milestone Aug 23, 2022
@kitography kitography merged commit 98ac457 into main Aug 23, 2022
@kitography kitography deleted the VAULT-7844-list-issuers-is-authenticated-and-shouldnt-be branch August 23, 2022 15:08
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipherboy cipherboy cipherboy approved these changes

@stevendpclark stevendpclark Awaiting requested review from stevendpclark

Assignees
No one assigned
Labels
bug Used to indicate a potential bug cryptosec secret/pki
Projects
None yet
Milestone
1.12.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@kitography @cipherboy